agile plugin doesn't work with easy redmine (easy gantt plugin) and etc..

2

Akishige TAKEKOSHI
Added almost 5 years ago

agile plugin uses `alias_method`, and there is compatibility problem.
Would you please check the following patch on `lib/redmine_agile/patches/queries_controller_patch.rb` ? (using `base.prepend`)

# This file is a part of Redmin Agile (redmine_agile) plugin,
# Agile board plugin for redmine
#
# Copyright (C) 2011-2020 RedmineUP
# http://www.redmineup.com/
#
# redmine_agile is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# redmine_agile is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with redmine_agile.  If not, see <http://www.gnu.org/licenses/>.

module RedmineAgile
  module Patches
    module QueriesControllerPatch
      def self.included(base)
        base.prepend(InstanceMethods)
      end

      module InstanceMethods
        def query_class
          return AgileChartsQuery if params[:type] == 'AgileChartsQuery'
          return AgileVersionsQuery if params[:type] == 'AgileVersionsQuery'
          super
        end
      end
    end
  end
end

unless QueriesController.included_modules.include?(RedmineAgile::Patches::QueriesControllerPatch)
  QueriesController.send(:include, RedmineAgile::Patches::QueriesControllerPatch)
end
Dimitar Chervenakov over 4 years

Hi. Sadly but we cannot guarantee that our plugins will be compatible with other third-party components (plugins) installed. As they are developed and designed by other developers and thus they work in a different way. However, we highly appreciate the effort you put for finding the solution. If you wish, our developers could check it (and add some additional source code changes if needed), however, it will be counted for paid service because of the above-mentioned reasons. In this case, please contact and mention what is the situation about.

Answers (5)

0

Andreas Sumerauer
Added almost 5 years ago

Thanks Akishige for sharing your patch!
Incidently I had reported the same issue just a couple of hours earlier to the forum.
I applied your patch and the problem is gone.
Thanks so much!

Andreas

Dimitar Chervenakov over 4 years

Hi, Andreas. Thanks for the feedback. Glad to know that the provided patch from Akishige is working correctly in your case. :)

-1

Dimitar Chervenakov
Added over 4 years ago

Hi. Sadly but we cannot guarantee that our plugins will be compatible with other third-party components (plugins) installed. As they are developed and designed by other developers and thus they work in a different way. However, we highly appreciate the effort you put for finding the solution. If you wish, our developers could check it (and add some additional source code changes if needed), however, it will be counted for paid service because of the above-mentioned reasons. In this case, please contact and mention what is the situation about.

1

(none) (none)
Added over 4 years ago

As of today, this patch still works like a charm ! Thanks for sharing.

It's certainly not part of your responsability to ensure the compatibility with other plugins, but well, let just say that there is plenty of agile plugins, but only one gantt plugin that allow drag and drops and easy date change like the one from easy... Even if we could also discuss what easy do and to be honest I take my time trying to find a non-easy equivalent without results.

So that's up to you, but if I had to choose... ;)

Dimitar Chervenakov about 4 years

Hi. Sadly but we cannot guarantee that our plugins will be compatible with other third-party components (plugins) installed. As they are developed and designed by other developers and thus they work in a different way. However, we highly appreciate the effort you put for finding the solution. If you wish, our developers could check it (and add some additional source code changes if needed), however, it will be counted for paid service because of the above-mentioned reasons. In this case, please contact and mention what is the situation about.

-1

(none) (none)
Added about 4 years ago

Hi
which version of the agile plugin is this patch for ?
thx

Dimitar Chervenakov about 4 years

Hi. Sadly but we cannot guarantee that our plugins will be compatible with other third-party components (plugins) installed. As they are developed and designed by other developers and thus they work in a different way. However, we highly appreciate the effort you put for finding the solution. If you wish, our developers could check it (and add some additional source code changes if needed), however, it will be counted for paid service because of the above-mentioned reasons. In this case, please contact and mention what is the situation about.

0

Vitaliy Tomin
Added over 1 year ago

this seems to be valid code:

# This file is a part of Redmin Agile (redmine_agile) plugin,
# Agile board plugin for redmine
#
# Copyright (C) 2011-2023 RedmineUP
# http://www.redmineup.com/
#
# redmine_agile is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# redmine_agile is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with redmine_agile.  If not, see <http://www.gnu.org/licenses/>.

module RedmineAgile
  module Patches
    module QueriesControllerPatch
      def self.prepended(base)
        base.prepend(InstanceMethods)
      end
      module InstanceMethods
        def query_class
          return AgileChartsQuery if params[:type] == 'AgileChartsQuery'
          return AgileVersionsQuery if params[:type] == 'AgileVersionsQuery'
          super
        end
      end
    end
  end
end

unless QueriesController.included_modules.include?(RedmineAgile::Patches::QueriesControllerPatch)
  QueriesController.send(:prepend, RedmineAgile::Patches::QueriesControllerPatch)
end
    (1-5/5)